Skip to content

TST: Add test case for GH14080 for overflow exception #23762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 18, 2018
Merged

TST: Add test case for GH14080 for overflow exception #23762

merged 4 commits into from
Nov 18, 2018

Conversation

eoveson
Copy link
Contributor

@eoveson eoveson commented Nov 18, 2018

@pep8speaks
Copy link

Hello @eoveson! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 18, 2018 •
edited
Loading

Codecov Report

Merging #23762 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23762   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         161      161           
  Lines       51408    51408           
=======================================
  Hits        47416    47416           
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 42.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bce1a...c727003. Read the comment docs.

mroeschke
mroeschke reviewed Nov 18, 2018
View reviewed changes
mroeschke
mroeschke reviewed Nov 18, 2018
View reviewed changes
@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Timedelta Timedelta data type labels Nov 18, 2018
gfyoung
gfyoung approved these changes Nov 18, 2018
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good now! LGTM.

@jreback jreback added this to the 0.24.0 milestone Nov 18, 2018
@jreback jreback merged commit 960a73f into pandas-dev:master Nov 18, 2018
@jreback
Copy link
Contributor

jreback commented Nov 18, 2018

thanks @eoveson

@eoveson
Copy link
Contributor Author

eoveson commented Nov 18, 2018

Thanks everyone for your feedback and the quick action on my pull request!

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@eoveson @tm9k1
TST: Add test case for GH14080 for overflow exception (pandas-dev#23762
f0b35f2 
)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@eoveson @Pingviinituutti
TST: Add test case for GH14080 for overflow exception (pandas-dev#23762
a97e9d5 
)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@eoveson @Pingviinituutti
TST: Add test case for GH14080 for overflow exception (pandas-dev#23762
ebfc96c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd left review comments

@mroeschke mroeschke mroeschke left review comments

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Timedelta Timedelta data type
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

Adding big offset to timedelta generates a python crash
7 participants
@eoveson @pep8speaks @jreback @WillAyd @gfyoung @mroeschke @erikoveson